Skip to content

[sui 4/x] - governance modules, update to sui 0.29.0 #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 28, 2023
Merged

[sui 4/x] - governance modules, update to sui 0.29.0 #732

merged 10 commits into from
Apr 28, 2023

Conversation

@optke3
Copy link
Contributor

@optke3 optke3 commented Mar 30, 2023 •
edited
Loading

Summary

  • Migrate governance-related modules from Aptos-Pyth
  • Make contracts compile, pass Pyth state and Wormhole state objects into function calls
  • Use Wormhole core deserialization, vaa libraries and sui::math library
  • Update to latest sui release 0.29.0, making changes were necessary (use public_transfer, public_share_object), and updating Move.toml to use updated Wormhole core bridge dependency, which recently updated to 0.29.0

Integration Remaining TODOs

  • Contract upgradeability, programmable transactions
  • Miscellaneous, e.g. error codes, failure test locations

Testing

sui move test or make test

Sui version: sui 0.29.1-d6ebeaa32

@vercel
Copy link

vercel bot commented Mar 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
xc-admin-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 6:50PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
example-oracle-amm ⬜️ Ignored (Inspect) Mar 31, 2023 at 6:50PM (UTC)

@optke3 optke3 changed the title [sui 4/x] - governance, update to sui 0.29.0 [sui 4/x] - governance modules, update to sui 0.29.0 Mar 30, 2023
@optke3 optke3 requested a review from Reisen March 30, 2023 18:49
@optke3 optke3 marked this pull request as ready for review March 30, 2023 18:49
Base automatically changed from sui/pyth to main March 31, 2023 18:43
@optke3 optke3 merged commit 2bbeb03 into main Apr 28, 2023
@optke3 optke3 deleted the sui/governance_ branch April 28, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Reisen Reisen Reisen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@optke3 @Reisen