[sdk] Move Solidity sdk into this repo #674
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
| run: npx lerna run test | ||
| - name: Lint | ||
| run: npx lerna run lint | ||
| - name: Generate ABIs |
There was a problem hiding this comment.
added these steps to the existing lerna pipeline instead of making a separate workflow. i think it should be faster this way because it doesn't have to install all of the npm packages in a separate thing, but def open to doing it a different way.
| "scripts": { | ||
| "format": "npx prettier --write .", | ||
| "generate-abi": "node scripts/generateAbi.js", | ||
| "build": "solcjs --bin MockPyth.sol -o build/" |
There was a problem hiding this comment.
this used to be named "build mock", and i changed it to build so it gets built with all the other packages above.
There was a problem hiding this comment.
does this work from here? can we add it to the top?
| ### pre-commit hooks | ||
|
|
||
| pre-commit is a tool that checks and fixes simple issues (formatting, ...) before each commit. You can install it by following [their website](https://pre-commit.com/). In order to enable checks for this repo run `pre-commit install` from command-line in the root of this repo. | ||
|
|
||
| The checks are also performed in the CI to ensure the code follows consistent formatting. |
There was a problem hiding this comment.
This is not necessary anymore
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Thank you very much.
|
the tilt CI is broken for a totally unrelated reason, so i'm going to merge this and then fix that. |
I want to experiment with adding some functions to this, and it's hard to work on when it's in a separate place.
This is a pure copy pr except for the minor changes called out in comments to unify the CI workflows. I've moved all the CI workflows except the one that publishes the NPM package, which I will do separately, as I also need to set up the js sdk publish pipelines.