[price-pusher] add workflow to push docker image #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
added 3 commits
March 7, 2023 11:17
0xfirefist
force-pushed
the
workflow/push/price-pusher
branch
from
2cb5438 to
a261a14
Compare
0xfirefist
commented
Mar 7, 2023
| registry: public.ecr.aws | ||
| env: | ||
| AWS_REGION: us-east-1 | ||
| - uses: aws-actions/amazon-ecr-login@v1 |
Contributor
Author
There was a problem hiding this comment.
do we need to do ecr_login? I see in price server workflow file we don't, but in price pusher workflow file in pyth-js we did. @ali-bahjati
ali-behjati
approved these changes
Mar 7, 2023
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Can you also update the dockerfiles?
Contributor
Author
I have updated them in a previous PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.