[wormhole-attester] Increase accuracy and improve logging #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [BREAKING CHANGE] min_interval_secs switches to milliseconds under
min_interval_ms
* attestation jobs no longer use preflight checks - this includes a
custom variant of send_and_confirm_transaction(), see util.rs for details
* attestation error logging no longer pretty-prints the error
structs ({:#?} became {:?})
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
ali-behjati
reviewed
Mar 2, 2023
ali-behjati
changed the title
guibescos
reviewed
Mar 2, 2023
| /// send_transaction() inside with | ||
| /// send_transaction_with_config(). This variant is currently missing | ||
| /// from solana_client. | ||
| pub async fn send_and_confirm_transaction_with_config( |
Contributor
There was a problem hiding this comment.
I wonder if dropping the confirm step would make this code better
Collaborator
There was a problem hiding this comment.
Yeah it makes it better but will make us blind on how much we are attesting successfully.
Contributor
Author
There was a problem hiding this comment.
Yeah, I think these results are critical to monitoring the service
guibescos
approved these changes
Mar 2, 2023
Contributor
guibescos
left a comment
guibescos
left a comment
There was a problem hiding this comment.
I don't understand the titlfile change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiltfile: TILT_DOCKER_REGISTRY def behavior, re-add namespace_create
This helped me with k8s setup details that caused me issues locally:
wormhole_attester/client v5.0.0: accuracy and logging opimisations
min_interval_ms
custom variant of send_and_confirm_transaction(), see util.rs for details
structs ({:#?} became {:?})