Skip to content

[xc-admin] add permission/depermission publisher keys for all asset types #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 23, 2023
Merged

[xc-admin] add permission/depermission publisher keys for all asset types #620

merged 6 commits into from
Feb 23, 2023

Conversation

@cctdaniel
Copy link
Contributor

@cctdaniel cctdaniel commented Feb 22, 2023

No description provided.

@vercel
Copy link

vercel bot commented Feb 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
xc-admin-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 23, 2023 at 1:44AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
example-oracle-amm ⬜️ Ignored (Inspect) Feb 23, 2023 at 1:44AM (UTC)

guibescos
guibescos requested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to handle case where there are 32 pubs

guibescos
guibescos requested changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@guibescos guibescos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to handle the case where the publisher already exists for some price feeds. Similarly, only delete it from those price feeds where it is permissioned. Maybe you should pass the entire priceAccounts[0] object to handleSubmit

@cctdaniel cctdaniel merged commit 8cb720c into main Feb 23, 2023
@cctdaniel cctdaniel deleted the general-commands branch February 23, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guibescos guibescos guibescos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cctdaniel @guibescos