[xc-admin] improve approve/reject UX #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
guibescos
requested changes
Feb 17, 2023
Contributor
guibescos
left a comment
guibescos
left a comment
There was a problem hiding this comment.
There's a bug where if you click in a proposal and then back to proposals. The proposal disappears.
Contributor
Author
can you try again? |
guibescos
reviewed
Feb 17, 2023
| const proposals = prevProposals.filter( | ||
| (proposal) => | ||
| proposal.publicKey.toBase58() !== | ||
| const index = prevProposals.findIndex( |
Contributor
There was a problem hiding this comment.
Nitpick : can you use currentProposalIndex for this? This seems inefficient
guibescos
approved these changes
Feb 17, 2023
Contributor
guibescos
left a comment
guibescos
left a comment
There was a problem hiding this comment.
Seems to be working now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.