Skip to content

Conversation

@0xfirefist
Copy link
Contributor

@0xfirefist 0xfirefist commented Feb 10, 2023

Completed

  • init package
  • move all the data structures to the package and consume them in the contract

Pending (to cover in other PRs)

  • add MockPyth to facilitate testing for pyth contract consumers
  • any helper function if required
  • generate schema
  • setup release pipeline
  • update contract to consume pyth-sdk-cw instead of pyth-cosmwasm.

@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated
example-oracle-amm ⬜️ Ignored (Inspect) Feb 10, 2023 at 6:33PM (UTC)
xc-admin-frontend ⬜️ Ignored (Inspect) Feb 10, 2023 at 6:33PM (UTC)

@0xfirefist 0xfirefist requested review from ali-behjati and jayantk and removed request for ali-behjati February 10, 2023 18:16
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. looks like you have a formatting issue. have you installed pre-commit ? instructions here https://github.com/pyth-network/pyth-crosschain#pre-commit-hooks

@0xfirefist
Copy link
Contributor Author

just fixed that!

@0xfirefist 0xfirefist merged commit 62083eb into main Feb 10, 2023
@0xfirefist 0xfirefist deleted the move-data-structures branch February 10, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants