[xc-admin] add proposals page #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
guibescos
reviewed
Feb 8, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Outdated
Show resolved
Hide resolved
guibescos
reviewed
Feb 8, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Outdated
Show resolved
Hide resolved
guibescos
reviewed
Feb 8, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Outdated
Show resolved
Hide resolved
guibescos
reviewed
Feb 8, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Outdated
Show resolved
Hide resolved
guibescos
reviewed
Feb 8, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Outdated
Show resolved
Hide resolved
guibescos
reviewed
Feb 8, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Outdated
Show resolved
Hide resolved
guibescos
approved these changes
Feb 8, 2023
Contributor
guibescos
left a comment
guibescos
left a comment
There was a problem hiding this comment.
It's looking really good, just make sure that unrecognized instructions also show. It can be very dangerous otherwise (proposal appears empty but has "hidden" bad instructions).
guibescos
reviewed
Feb 9, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Show resolved
Hide resolved
cctdaniel
force-pushed
the
xc-admin-proposals
branch
from
d64ece9 to
cebc603
Compare
guibescos
reviewed
Feb 9, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Outdated
Show resolved
Hide resolved
guibescos
reviewed
Feb 9, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Outdated
Show resolved
Hide resolved
cctdaniel
force-pushed
the
xc-admin-proposals
branch
from
d5776d0 to
a7fe128
Compare
guibescos
reviewed
Feb 10, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Show resolved
Hide resolved
guibescos
reviewed
Feb 10, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Show resolved
Hide resolved
guibescos
reviewed
Feb 10, 2023
governance/xc_admin/packages/xc_admin_frontend/components/tabs/Proposals.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.