[price-service] Improve and update tests #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jayantk
approved these changes
Jan 23, 2023
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
very nicely done. and thank you for adding tests!
cctdaniel
approved these changes
Jan 24, 2023
Contributor
cctdaniel
left a comment
cctdaniel
left a comment
There was a problem hiding this comment.
thanks for adding test ser 🫡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the existing tests and adds test for the newly added
get_vaaendpoint. Also adds tests to the tilt so we never miss them.listen.tsis changed slightly to make testing easier.