[xc-admin] min pub page #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cctdaniel
commented
Jan 24, 2023
|
|
||
| return () => {} | ||
| return () => { | ||
| cancelled = true |
Contributor
Author
There was a problem hiding this comment.
without this line, and the added lines above, it broke the site because it was returning multiple cluster data and the order wasn't preserved
Contributor
There was a problem hiding this comment.
Me not understand but I'll trust you
guibescos
reviewed
Jan 24, 2023
| )!.address | ||
|
|
||
| pythProgramClient.methods | ||
| .setMinPub(newMinPublishers, [0, 0, 0]) |
Contributor
There was a problem hiding this comment.
In accounts, you need to make fundingAccount : squads?.getAuthorityPDA( SECURITY_MULTISIG[getMultisigCluster(cluster)], 1 ) otherwise the multisig won't sign the transaction
guibescos
requested changes
Jan 24, 2023
Contributor
guibescos
left a comment
guibescos
left a comment
There was a problem hiding this comment.
Need to fix :
- proposal accounts
- video that I sent you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.