[xc-admin] Decoders can't throw

[guibescos]

Try to switch to a world where nothing can throw errors.

• Update decode to not throw and instead return undefined
• resolveAccountName can't throw

How undefined are handled :

• 1. If we don't recognize the program of the instruction, it becomes UnrecognizedProgram implements MultisigInstruction which stores the instruction (useful to print the instruction)
• 2. If we don't recognize an instruction in PythMultisigInstruction or WormholeMultisigInstruction the name of the instruction is set to unrecognizedInstruction instead of for example postMessage or addPrice.
• 3. If we recognize a postMessage in WormholeMultisigInstruction but we can't deserialize the wormhole payload wormholeMultisigInstruction.governanceAction will be undefined, but the payload is stored in wormholeMultisigInstruction.args.payload

It think it's good to distinguish the 3 cases because the undefined is at a different depth. It ends up being a little bit inconsistent, but ultimately it is because we use anchor to deserialize the instructions and that part somehow breaks the types.

[guibescos]

buffer-layout can throw errors, so we need to handle them here so the user of our structs won't have to deal with them

[jayantk]

seems like a reasonable approach to me.

One thing I'll note is that I don't think you can necessarily decode -> encode if you have an unrecognized instruction. I'm not sure whether that's important though (maybe not)

[guibescos]

seems like a reasonable approach to me.

One thing I'll note is that I don't think you can necessarily decode -> encode if you have an unrecognized instruction. I'm not sure whether that's important though (maybe not)

I think you can because the args field of unkwownInstruction contains the instruction data.