Skip to content

Conversation

@jayantk
Copy link
Contributor

@jayantk jayantk commented Jan 11, 2023

No description provided.

@ali-behjati ali-behjati changed the title Document the spy filters [price-service] Document the spy filters Jan 11, 2023
@ali-behjati ali-behjati changed the title [price-service] Document the spy filters [price-service] Document the spy filters in .env.sample Jan 11, 2023
SPY_SERVICE_HOST=0.0.0.0:7072

## Filters (if provided) should be valid JSON like below:
# Filters (if provided) should be valid JSON like below:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not valid jsons 🤔

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary but it's fine. We already explained them in README too and exact values are in the docker files (and readme mentions them)

@ali-behjati ali-behjati merged commit 7c2e02e into main Jan 11, 2023
@ali-behjati ali-behjati deleted the doc_spy_filters branch January 11, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants