Injective deployment code #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
Jan 9, 2023
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
generally this looks good to me. I left a couple minor suggestions for how to tidy up the code a little more, but overall nicely done. I'm going to approve this, but please do implement the code cleanup suggestions before merging.
ali-behjati
approved these changes
Jan 9, 2023
Collaborator
There was a problem hiding this comment.
Looks very good to me 🎉 . Please also fix Tilt CI before merging. deploy.ts is used for tilt which is our local development enviornment; it would be great if that can also use your great work!
You need to update the deploy.sh file in the tools directory that tilt runs in its service (look at tilt-devnet/k8s/terra-devnet.yaml)
added 8 commits
January 9, 2023 22:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add to the work done in this #455 by @jayantk
Q. do we still need deploy.ts? what purpose does it serve?