Xc admin/propose instructions #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
force-pushed
the
xc-admin/propose-instructions
branch
from
f74f592 to
c676db1
Compare
jayantk
approved these changes
Jan 10, 2023
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
I think you may need to refactor this code a bit once you get more stuff written, but I'm going to approve this for now. (I think you'll probably want to develop a systematic organization for the different types of instructions, which will include some representation for remote vs. local instructions. anyway that's something you can do later.)
| vault: PublicKey, | ||
| instructions: TransactionInstruction[], | ||
| remote: boolean, | ||
| wormholeAddress?: PublicKey |
Contributor
There was a problem hiding this comment.
make a class like MultisigWrapper to encapsulate some of the common arguments (squads, wormholeAddress, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffolding for a function that proposes an array of instructions as local chain instructions or remote instructions.
I'm hoping to test it once the other pieces are implemented.
The main challenge for this part of the code is batching instructions into transactions. We don't want a ledger user's to have to sign too many transactions. Simultaneously, all instructions might not fit in one transaction.
The current (naive) solution is having 1 instruction per transaction, having the ledger sign all transactions at once and then sending all transactions. This might need to change but don't want to focus on this until we can test it in the UI.