[cosmos] Misc code cleanup #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
commented
Dec 29, 2022
| governance_sequence_number: msg.governance_sequence_number, | ||
| valid_time_period: Duration::from_secs(msg.valid_time_period_secs as u64), | ||
| fee: msg.fee, | ||
| fee_denom: msg.fee_denom, |
Contributor
Author
There was a problem hiding this comment.
fee is a Coin now so it has the denom already
jayantk
commented
Dec 29, 2022
| env: Env, | ||
| info: MessageInfo, | ||
| data: &Binary, | ||
| data: &[Binary], |
Contributor
Author
There was a problem hiding this comment.
Pass in an array of price updates to update_price_feeds for consistency with the EVM implementation.
jayantk
commented
Dec 29, 2022
| } | ||
| _ => Err(PythContractError::InvalidGovernancePayload)?, | ||
| } | ||
| transfer_governance(&mut updated_config, &state, &parsed_claim_vaa)? |
Contributor
Author
There was a problem hiding this comment.
moved to helper function (per previous PR comment)
jayantk
commented
Dec 29, 2022
| emitter: vaa.emitter_address.clone().into(), | ||
| pyth_emitter_chain: vaa.emitter_chain, | ||
| emitter: vaa.emitter_address.clone().into(), | ||
| chain_id: vaa.emitter_chain, |
Contributor
Author
There was a problem hiding this comment.
(I renamed this field in data source)
jayantk
commented
Dec 29, 2022
| SetValidPeriod, | ||
| }, | ||
| state::PythDataSource, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
fix same file imports (per previous PR)
jayantk
commented
Dec 29, 2022
| QueryMsg::GetValidTimePeriod => to_binary(&get_valid_time_period(deps)?), | ||
| QueryMsg::PriceFeed { id } => to_binary(&query_price_feed(&deps, env, id.as_ref())?), | ||
| QueryMsg::GetUpdateFee { vaas } => to_binary(&get_update_fee(&deps, &vaas)?), | ||
| QueryMsg::GetValidTimePeriod => to_binary(&get_valid_time_period(&deps)?), |
Contributor
Author
There was a problem hiding this comment.
changed signature to borrow (for consistency with the rest of the functions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up a few miscellaneous issues from earlier PRs. Main changes are:
I suggest reading
msg.rsandstate.rsfirst to get the main changes before looking atcontract.rs(which is mostly mechanical)..