[price-service] Fine-tune metrics #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove nodejs default metrics. We don't use them. - Remove `path` from response time metric. - Remove freshness metric and add gap metric. They are similar; however, freshness was measured upon user request but gap is measured upon receiving the next update. - Change receivedVaa to actually represent distinct vaa received. Prior to this, the older vaas, or vaas with same attestation time were not counted in this metric. This will also improve the performance. - Refactors the code a little. `vaaBytes` type was not string and was Buffer. It is fixed now.
ali-behjati
changed the title
Contributor
|
@ali-bahjati there are better ways to set up response time tracking. You can leave that part out and I'll take care of it. |
jayantk
approved these changes
Nov 30, 2022
It can be measured on ingress/service level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are similar; however, freshness was measured upon user request but gap is
measured upon receiving the next update.
to this, the older vaas, or vaas with same attestation time were
not counted in this metric. This will also improve the performance.
vaaBytestype was not string and wasBuffer. It is fixed now.