Dockerfile.client, Dockerfile.solana: harden caching to cut CI time #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change attempts to add useful items to the docker caching which should save time downloading crates and by adding path=<full path> and dropping id=<name> ensure that no Dockerfile cache mismatches occur. I think the id= param is meant to help group builds that benefit from common cache, but in case of pyth2wormhole-client/SOL contract builds it became a competition between the two replacing the other's caches
ali-behjati
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to add useful items to the docker caching which should save time downloading crates and by adding path= and dropping id= ensure that no Dockerfile cache mismatches occur. I think the id= param is meant to help group builds that benefit from common cache, but in case of pyth2wormhole-client/SOL contract builds it became a competition between the two replacing the other's caches