fix: fixed nuqs usage by doing a pass-through export from a new package and clamping package to ESM #3178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge and clamping package to ESM
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cprussin
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue from this Slack thread
Summary
Created a
@pythnetworks/react-hookspackage that currently just re-exportsnuqs, but can be used as a place to put shared hooks in the future. Also upgrade ts-duality to the latest version, which no longer formats the built files that are rendered intodist/(which was not valuable, anyways)Rationale
Per discourse here, using
nuqsin a monorepo with packages and bundlers that support mixed exports between CJS and ESM, some codepaths can import the CJS variant, whereas others import the ESM variant, which causes runtime issues since the contexts are different.How has this been tested?
Loaded the Pyth Insights price feeds page, clicked around and ensured that nothing blew up at runtime.
Screenshots
Before
After