chore(dev-hub) Component: Integration Card #3176
Open
+380
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
aditya520
changed the title
alexcambose
reviewed
Nov 6, 2025
Comment on lines
+90
to
+91
| key={index} | ||
| href={link.href} |
There was a problem hiding this comment.
nit href should be unique since the links are unique so you can do key={link.href}
| letter-spacing: -0.03em; // -0.9px | ||
| color: var(--color-fd-foreground); | ||
| white-space: nowrap; | ||
| overflow: visble; |
alexcambose
force-pushed
the
chore(dev-hub)-integration-card
branch
from
9b1f3b7 to
d61e9a2
Compare
alexcambose
reviewed
Nov 6, 2025
Comment on lines
+5
to
+11
|
|
||
| padding: 2rem 1rem; | ||
|
|
||
| @media (width >= 768px) { | ||
| padding: 3rem 1.5rem; | ||
| } | ||
| } |
There was a problem hiding this comment.
can we please use more utils from the theme file
| align-items: center; | ||
| justify-content: flex-start; | ||
|
|
||
| :global(button) { |
There was a problem hiding this comment.
the button component can take a custom class so we don't have to do this kind of selection
Comment on lines
+73
to
+85
| margin: 0; | ||
| font-size: 1rem; // 16px | ||
| font-weight: 400; | ||
| line-height: 1.65; | ||
| letter-spacing: -0.01em; // -0.16px | ||
| color: var(--color-fd-foreground); | ||
| opacity: 0.9; | ||
| overflow: visible; | ||
| display: -webkit-box; | ||
| -webkit-line-clamp: 3; | ||
| line-clamp: 3; | ||
| -webkit-box-orient: vertical; | ||
| flex: 1; |
There was a problem hiding this comment.
tbh so many of these css rules are not really doing anything or relevant...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?