chore: export reusable useCopy hook #3172
Merged
+46
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fhqvst
approved these changes
Nov 3, 2025
Contributor
fhqvst
left a comment
fhqvst
left a comment
There was a problem hiding this comment.
lgtm
two tiny nits:
- i'd probably not have the
useEffects at all, but instead just keep all the logic in thecopycallback - in theory i think we need to check if we're still mounted before we call
setIsCopied, but in practice i don't think this matters
Contributor
Author
|
yeah that's true, kinda just copy pasted that from the existing code. I can change it with the next pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?