-
Notifications
You must be signed in to change notification settings - Fork 308
fix(TON): gas optimizations to enable parsePriceFeeds for 8 price ids in one instruction #2925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
This reverts commit 2286743.
tejasbadadare
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our existing TON code could not parse price feed updates for updates with more than 7 price feeds. This was because the gas usage for those instructions exceeded the max gas limit for TON transactions (1,000,000). The TON people needed at least 8 in an instruction. This optimization fix cuts down on gas usage enough to do that.
The read_and_store_large_data method used to conduct a double reversal process -- it would split the input data up into chunks through a linked list whose head was at the end of the data and tail at the start. It would then again traverse the linked list to reverse that reversed sequence. My optimization splits the input data into its chunks in a forward approach, avoiding the requirement to reverse and re-reverse.
How has this been tested?
Validated against existing tests, and added a new test for 8 price feeds to make sure that worked. In addition, I previously had tests for 9 and 11 price feeds, but those instructions exceeded the gas limit.