fix(fortuna): Fix bug in get_request_v2 #2902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jayantk
commented
Jul 26, 2025
| use_blockhash: request.use_blockhash, | ||
| callback_status: reader::RequestCallbackStatus::try_from(request.callback_status)?, | ||
| })) | ||
| if request.sequence_number == 0 { |
Contributor
Author
There was a problem hiding this comment.
get_request returns inactive requests and then it's the caller's responsibility to check. see https://github.com/pyth-network/pyth-crosschain/blob/main/target_chains/ethereum/contracts/contracts/entropy/Entropy.sol#L1072
tejasbadadare
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I introduced a bug in this method in the PR when I upgraded fortuna to handle the v2 contract. This bug is breaking the stats on callback errors.
How has this been tested?