feat(pyth-lazer) Add support for FundingRateInterval in lazer protos #2891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bplatak
changed the title
Riateche
requested changes
Jul 25, 2025
Comment on lines
57
to
61
| enum FundingRateInterval { | ||
| INTERVAL_1H = 0; | ||
| INTERVAL_4H = 1; | ||
| INTERVAL_8H = 2; | ||
| } |
Contributor
There was a problem hiding this comment.
Doesn't seem like a good idea to restrict the possible set of values here. Why not use a Duration?
Collaborator
There was a problem hiding this comment.
yeah, maybe in the future people have half an hour too :D
Riateche
approved these changes
Jul 29, 2025
Contributor
Riateche
left a comment
Riateche
left a comment
There was a problem hiding this comment.
Please see one comment below. Otherwise, LGTM!
| pub confidence: Option<Price>, | ||
| pub funding_rate: Option<Rate>, | ||
| pub funding_timestamp: Option<TimestampUs>, | ||
| pub funding_rate_interval: Option<u64>, |
Contributor
There was a problem hiding this comment.
We should use DurationUs here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new field to represent funding rate interval to funding rate update messages in protobuf objects and jrpc domain.
Rationale
We're adding support for variable funding rate updates in lazer as part of PF-278
How has this been tested?