feat(stylus) - get prices pyth contract functions #2794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace incorrect .try_read().ok_or() with proper .get() method calls - Add zero-value check for publish_time to determine if price data exists - Contract now compiles successfully without StorageGuard errors Co-Authored-By: [email protected] <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ali-behjati
approved these changes
Jun 30, 2025
tejasbadadare
approved these changes
Jun 30, 2025
|
|
||
| pub fn get_price_no_older_than(&self, _id: [u8; 32], _age: u64) -> PriceInfoReturn { | ||
| (U64::ZERO, I32::ZERO, I64::ZERO, U64::ZERO, I64::ZERO, U64::ZERO) | ||
| pub fn get_price_no_older_than(&self, _id: [u8; 32], _age: u64) -> Result<PriceInfoReturn, PythReceiverError> { |
Contributor
There was a problem hiding this comment.
Not necessary right now (you can do this in a future PR,) but let's move the public components that users will consume like structs and errors into an SDK. That way they can import just the public SDK to consume prices and use the contracts. The private impls will stay in the contract, but will implement the public SDK interfaces. Example here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented the get prices functions of the pyth stylus contract.
Rationale
Important for getting most recent prices, and has an important function definition for making sure that an update is no older than a certain specified age (is_no_older_than).
How has this been tested?
Get prices can only be evaluated when other parts of the contract are completed (i.e. initialization). Until then, cargo build is the main system by which I'm verifying things work.