-
Notifications
You must be signed in to change notification settings - Fork 307
feat(stylus) - Initialize pyth stylus #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good here, you can address the feedbacks on the following ones. Why are you not merging this in main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suppose you remove it later no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup!
| } | ||
|
|
||
| // PriceInfo struct storing price information | ||
| pub type PriceInfoReturn = (U64, I32, I64, U64, I64, U64); No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not a named struct here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running into some versioning errors that were preventing me, I'll need to fix versioning on the wormhole contract
| name = "stylus-hello-world" | ||
| version = "0.1.11" | ||
| edition = "2021" | ||
| license = "MIT OR Apache-2.0" | ||
| homepage = "https://github.com/OffchainLabs/stylus-hello-world" | ||
| repository = "https://github.com/OffchainLabs/stylus-hello-world" | ||
| keywords = ["arbitrum", "ethereum", "stylus", "alloy"] | ||
| description = "Stylus hello world example" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls update the placeholder values
Summary
Initializing and defining the framework for the Pyth-receiver contract in stylus.
Rationale
The whole receiver contract is necessary for getting Arbitrum chain programs to be able to interact with Pyth Network. This particular PR runs the necessary initialization steps.
How has this been tested?
No new functionality, so a simple cargo build makes sure things work for now.