Skip to content

feat(fortuna): extract RETRY_PREVIOUS_BLOCKS into EthereumConfig #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

feat(fortuna): extract RETRY_PREVIOUS_BLOCKS into EthereumConfig #2713

merged 3 commits into from
May 21, 2025

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented May 21, 2025

Extract RETRY_PREVIOUS_BLOCKS into EthereumConfig

Description

This PR extracts the hardcoded RETRY_PREVIOUS_BLOCKS constant from block.rs into a configurable field in the EthereumConfig struct. The default value in the config is set to the current hardcoded value (100).

Changes

  • Added a new field retry_previous_blocks to EthereumConfig struct in config.rs
  • Created a default function that returns the current value (100)
  • Modified watch_blocks_wrapper and watch_blocks functions to accept retry_previous_blocks as a parameter
  • Updated the call to watch_blocks_wrapper in run_keeper_threads to pass the config value
  • Added #[allow(dead_code)] to the constant to keep it for backward compatibility

Testing

  • Verified changes with pre-commit hooks
  • Ensured code compiles and passes linting

Link to Devin run

https://app.devin.ai/sessions/1e0c733957604bcb9b8e5e9bdab120a9

Requested by: Jayant Krishnamurthy ([email protected])

@devin-ai-integration
Copy link
Contributor Author

devin-ai-integration bot commented May 21, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link

vercel bot commented May 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:25pm
component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:25pm
developer-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:25pm
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:25pm
entropy-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:25pm
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:25pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:25pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 3:25pm

@devin-ai-integration
style: format keeper.rs
5a93116 
Co-Authored-By: Jayant Krishnamurthy <[email protected]>
jayantk
jayantk reviewed May 21, 2025
View reviewed changes
apps/fortuna/src/keeper/block.rs Outdated
const POLL_INTERVAL: Duration = Duration::from_secs(2);
/// Retry last N blocks
#[allow(dead_code)]
const RETRY_PREVIOUS_BLOCKS: u64 = 100;
Copy link
Contributor

@jayantk jayantk May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete this constant

@jayantk jayantk merged commit 0b1a59f into main May 21, 2025
4 of 8 checks passed
@jayantk jayantk deleted the devin/1747837359-add-retry-blocks-config branch May 21, 2025 15:21
m30m added a commit that referenced this pull request May 21, 2025
@m30m
Revert "feat(fortuna): extract RETRY_PREVIOUS_BLOCKS into EthereumCon…
6c27d8d 
…fig (#2713)"

This reverts commit 0b1a59f.
m30m added a commit that referenced this pull request May 22, 2025
@m30m
feat(fortuna): Improve explorer (#2717)
8378698 
* Revert "feat(fortuna): extract RETRY_PREVIOUS_BLOCKS into EthereumConfig (#2713)"

This reverts commit 0b1a59f.

* optional provider random number in case of failure

* add gas

* more fields

* limit and offset

* add network id as the main identifier

* bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayantk jayantk jayantk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jayantk