feat(fortuna): better logging + avoid unnecessary fee syncs #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jayantk
approved these changes
May 21, 2025
| fee: 1500000000000000 | ||
|
|
||
| # Set this temporarily to false if you have changed the fees and want to apply a new baseline fee. | ||
| sync_fee_only_on_register: true |
Contributor
There was a problem hiding this comment.
I think this is a brittle config flag -- people will forget to unset it. I think it is better to auto-detect whether or not you need to set the fees differently.
E.g., can we run the same code we run in the keeper to set the fees based on the gas price?
Contributor
Author
There was a problem hiding this comment.
there is some state involved there (we don't update the fees if we are not seeing any new requests). I will add another task to improve it but since nothing bad happens if people forget to unset it, I think this is a good default behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
Whenever we deploy a new version or change some configuration, the setup script is executed and fees are synced to the default value. This is unnecessary and can cause problems for some of the requests made within the duration that the fee is reset (if the users are paying for the fee and the value sent to our contract is the tx value signed by user).
How has this been tested?