fix(pulse): reset priceLastUpdatedAt when price IDs are added in updateSubscription #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubscription Co-Authored-By: Tejas Badadare <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
3 tasks
Contributor
Author
|
Closing due to inactivity for more than 7 days. |
ali-behjati
approved these changes
May 27, 2025
Comment on lines
134
to
144
| bool priceIdsChanged = _clearRemovedPriceUpdates( | ||
| subscriptionId, | ||
| currentParams.priceIds, | ||
| newParams.priceIds | ||
| ); | ||
|
|
||
| // Reset priceLastUpdatedAt to 0 if price IDs have changed | ||
| if (priceIdsChanged) { | ||
| _state.subscriptionStatuses[subscriptionId].priceLastUpdatedAt = 0; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It would be more accurate to reset priceLastUpdatedAt only when new prices are added (not just on any change to price ids.)
Co-Authored-By: Tejas Badadare <[email protected]>
tejasbadadare
changed the title
…evin/1747071611-reset-pricelastupdatedat-on-subscription-update
tejasbadadare
deleted the
devin/1747071611-reset-pricelastupdatedat-on-subscription-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset priceLastUpdatedAt when price IDs are added in updateSubscription
Description
This PR fixes an issue in the
Scheduler.solcontract wherepriceLastUpdatedAtwas not being reset when thepriceIdslist was added to in theupdateSubscriptionfunction. This could prevent immediate calls toupdatePriceFeedsafter a subscription update because:heartbeatSecondsenforces a minimum time sincepriceLastUpdatedAtpublishTimegreater thanpriceLastUpdatedAtThe fix modifies the
_clearRemovedPriceUpdatesfunction to return a boolean indicating whether price IDs have been added, and then resetspriceLastUpdatedAtto 0 inupdateSubscriptionwhen this occurs.Changes
_clearRemovedPriceUpdatesto return a boolean indicating if price IDs were addedupdateSubscriptionto resetpriceLastUpdatedAtto 0 when price IDs are addedPulseScheduler.t.solto verify the fix works as expectedTesting
testUpdateSubscriptionResetsPriceLastUpdatedAtthat verifies:priceLastUpdatedAtis reset to 0 when price IDs are addedRequested by
Tejas Badadare ([email protected])
Link to Devin run
https://app.devin.ai/sessions/143f676aadca48d8a5e491864dff0917