fix(pulse): enforce min bal for all active updated subs #2642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b/pulse/enforce-min-bal-for-all-active-updated-subs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
ali-behjati
approved these changes
May 1, 2025
tejasbadadare
deleted the
tb/pulse/enforce-min-bal-for-all-active-updated-subs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enforce minimum balance in updateSubscription even when reducing or keeping the number of feeds the same.
Rationale
Initially we didn't enforce the check if the user is decreasing their feed count or keeping it the same. The thought was to be friendly to the user in case they are trying to reduce their funds burn rate. However, this is inconsistent behavior and might actually confuse the user, and it's safer to always check. Now, in all cases where the sub is getting updated and remaining active, the check is enforced.
How has this been tested?