Skip to content

refactor(pulse): remove mention of gas config in sub param validation #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

refactor(pulse): remove mention of gas config in sub param validation #2641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions target_chains/ethereum/contracts/contracts/pulse/Scheduler.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ abstract contract Scheduler is IScheduler, SchedulerState {
function createSubscription(
SubscriptionParams memory subscriptionParams
) external payable override returns (uint256 subscriptionId) {
// Validate params and set default gas config
_validateAndPrepareSubscriptionParams(subscriptionParams);
_validateSubscriptionParams(subscriptionParams);

// Calculate minimum balance required for this subscription
uint256 minimumBalance = this.getMinimumBalance(
Expand Down Expand Up @@ -98,9 +97,7 @@ abstract contract Scheduler is IScheduler, SchedulerState {
emit SubscriptionUpdated(subscriptionId);
return;
}

// Validate the new parameters, including setting default gas config
_validateAndPrepareSubscriptionParams(newParams);
_validateSubscriptionParams(newParams);

// Check minimum balance if number of feeds increases and subscription remains active
if (
Expand Down Expand Up @@ -151,11 +148,10 @@ abstract contract Scheduler is IScheduler, SchedulerState {
}

/**
* @notice Validates subscription parameters and sets default gas config if needed.
* @dev This function modifies the passed-in params struct in place for gas config defaults.
* @param params The subscription parameters to validate and prepare.
* @notice Validates subscription parameters.
* @param params The subscription parameters to validate.
*/
function _validateAndPrepareSubscriptionParams(
function _validateSubscriptionParams(
SubscriptionParams memory params
) internal pure {
// No zero‐feed subscriptions
Expand Down
Loading