feat: add a staking endpoint to return a stake summary per account #2535
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
cprussin
force-pushed
the
cprussin/add-staking-endpoint-to-return-positions-by-wallet
branch
from
22de8e2 to
64177c2
Compare
| // Safe because `min(1)` guarantees that `data` is nonempty | ||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| Buffer.from(data[0]!, "base64"), |
There was a problem hiding this comment.
nit: can we use an if to avoid having !?
There was a problem hiding this comment.
In this case we actually want ! because the min(1) line from Zod already guarantees the length, but can't encode that in the type. I generally prefer letting Zod verify this kind of thing since it will generate nice consistent error messages, but it requires the ! to avoid having a second null check at runtime. In this case since it's so many accounts, it's not huge but it is actually a relevant optimization.
I usually wrap this kind of thing into a nonEmptyArray Zod helper which returns [T, ...T[]] instead of T[] which typescript can then guarantee is nonempty...
cprussin
force-pushed
the
cprussin/add-staking-endpoint-to-return-positions-by-wallet
branch
from
64177c2 to
cfd9a57
Compare
cprussin
force-pushed
the
cprussin/add-staking-endpoint-to-return-positions-by-wallet
branch
from
cfd9a57 to
2724816
Compare
cprussin
force-pushed
the
cprussin/add-staking-endpoint-to-return-positions-by-wallet
branch
from
2724816 to
9bbc2ed
Compare
cprussin
force-pushed
the
cprussin/add-staking-endpoint-to-return-positions-by-wallet
branch
from
9bbc2ed to
3d461e5
Compare
cprussin
deleted the
cprussin/add-staking-endpoint-to-return-positions-by-wallet
branch
Summary
Adds an endpoint to the staking app to return a stake summary per account.
Rationale
This is required to calculate Fogo flames
How has this been tested?