Skip to content

Conversation

@ali-behjati
Copy link
Collaborator

@ali-behjati ali-behjati commented Aug 17, 2022

Release price service and removes guardian image and uses wormhole published image for "guardian node" and "spy"

@ali-behjati ali-behjati requested review from jayantk and thmzlt August 17, 2022 11:51
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm going to let @thmzlt review this because i'm not super up to date on all this docker stuff.

@thmzlt
Copy link
Contributor

thmzlt commented Aug 17, 2022

Also, I thought we were going to use the ECR repositories (xc-attest, xc-spy, xc-server) that we created last week?

@ali-behjati ali-behjati requested review from jayantk and thmzlt August 18, 2022 16:22
@thmzlt
Copy link
Contributor

thmzlt commented Aug 18, 2022

The new ECR repos for xc-attest and xc-server:

  • public.ecr.aws/pyth-network/xc-attest
  • public.ecr.aws/pyth-network/xc-server

I think the ecr_login action doesn't work too well with public ECR repos so I ended up using the regular docker-login action in program_admin. All public ECR repos must be on the us-east-1 region.

You can look at the program-admin build-and-push-ecr job for a full example of how to push to a public ECR repo. It's not all that different.

@ali-behjati ali-behjati merged commit 586eba0 into main Aug 22, 2022
@ali-behjati ali-behjati deleted the abehjati/release-price-service branch August 22, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants