fix(lazer/aptos-contract): add coin conversion map to tests #2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
keyvankhademi
approved these changes
Mar 11, 2025
tejasbadadare
deleted the
tb/lazer-aptos-contract/fix-ecoin-conversion-map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix Aptos contract CI by explicitly creating a coin conversion map in the test setup.
Rationale
A recent update to the
AptosFrameworkdependency made it required to explicitly define a coin conversion map when initializing a coin. We init an APT coin in tests to verify fee withdrawals. Since our dep was pointed tomainnet, this caused CI to randomly start failing. This fix adheres to the requirement and also pins the version to the latest revision to avoid other surprises from deps.How has this been tested?