feat(hermes-client): allow passing fetch options #2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
cctdaniel
approved these changes
Feb 6, 2025
This PR enables passing the `RequestInit` options for `fetch` to individual `HermesClient` methods. This PR also fixes merging `AbortControllers`, which was previously not done correctly (but also no way to pass an `AbortController` was actually exposed via the public API, so this is not a breaking change), and upgrades typescript to the catalog version, which is required to support `AbortSignal.any`.
cprussin
force-pushed
the
cprussin/allow-passing-fetch-arguments-to-hermes-client
branch
from
0a05633 to
4624180
Compare
cprussin
deleted the
cprussin/allow-passing-fetch-arguments-to-hermes-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables passing the
RequestInitoptions forfetchto individualHermesClientmethods.This PR also fixes merging
AbortControllers, which was previously not done correctly (but also no way to pass anAbortControllerwas actually exposed via the public API, so this is not a breaking change), and upgrades typescript to the catalog version, which is required to supportAbortSignal.any.