fix(hermes): tune readiness probe #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This change modifies the not_behind readiness indicator to use the most recent slot from Pythnet accumulator instead of taking the max because we think that during forks validators might return an absurdly large slot. It also makes it more verbose by returning the indicators and the initial values for them so we can investigate better if the issue persists.
ali-behjati
force-pushed
the
fix/hermes-readiness
branch
from
634f85f to
591ffc0
Compare
Reisen
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the not_behind readiness indicator to use the most recent slot from Pythnet accumulator instead of taking the max because we think that during forks validators might return an absurdly large slot. It also makes it more verbose by returning the indicators and the initial values for them so we can investigate better if the issue persists.