fix(apps/hermes/client): allow baseURL with suffixes #1728
Conversation
|
@mubaris is attempting to deploy a commit to the pyth-web Team on Vercel. A member of the Team first needs to authorize it. |
mubaris
changed the title
| filter?: string; | ||
| }): Promise<PriceFeedMetadata[]> { | ||
| const url = new URL("/v2/price_feeds", this.baseURL); | ||
| const url = new URL(`${this.baseURL}/v2/price_feeds`); |
There was a problem hiding this comment.
I think we should keep the current structure but make the path relative e.g.
const url = new URL('v2/price_feeds', baseURL);
The URL constructor ensures that the protocol and host parts of the base URL are preserved correctly, even if the base URL has additional path components.
If you could also make the changes for getLatestPriceUpdates and getPriceUpdatesAtTimestamp that would be appreciated!
cctdaniel
left a comment
cctdaniel
left a comment
There was a problem hiding this comment.
Thanks for catching the bug and opening a PR, left a comment and happy to look again once that's addressed.
|
thanks for your contribution! can you bump the package version? |
|
done! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
2 participants
No description provided.