feat(apps/price_pusher)!: switch to structured logger via pino #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
cprussin
requested changes
Jun 19, 2024
Collaborator
cprussin
left a comment
cprussin
left a comment
There was a problem hiding this comment.
Pino is awesome! Great call moving this over.
Mostly LGTM but I'd definitely recommend removing pino-pretty from the production dependencies.
I'm not familiar with the interfaces enough here but is there an option to pass a logger instance to any entrypoint that a library would consume? If not, I strongly recommend adding one -- it's very common for apps to have their own pino (or bunyan) instances and to want to use a child logger for a library.
cprussin
approved these changes
Jun 19, 2024
jayantk
approved these changes
Jun 19, 2024
This change switches from `console` to `pino` for logging that is a structured logger and allows us to have json formatted loggers. In adition to just that change, pino does an amazing job at logging the errors by including all their data + the stacktrace. This change does minimal change to the log level and the `console.log` is changed to info or debug level based on my judgement. This change is marked as breaking because it breaks any reliability/ops based on the logs.
ali-behjati
force-pushed
the
price_pusher/use-pino
branch
from
b9dfac1 to
0169fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches from
consoletopinofor logging that is a structured logger and allows us to have json formatted loggers. In adition to just that change, pino does an amazing job at logging the errors by including all their data + the stacktrace.This change does minimal change to the log level and the
console.logis changed to info or debug level based on my judgement.This change is marked as breaking because it breaks any reliability/ops based on the logs.
The attached images show the new log outputs in both pretty and json formats, as well as error logs.