fix(target_chains/fuel): update js sdk to properly gen and export types #1703
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
target_chains/fuel/sdk/js/src/types/factories/PythContractAbi__factory.ts
Show resolved
Hide resolved
This change adds type generation to the build path to have them in the resulting library and also fixes the issues around type exports by updating the typescript and using `export type *`. The problem was that the normal `export *` adds a similar export to the produced js file but there is no module to be exported from in our case.
ali-behjati
force-pushed
the
fix-fuel-sdk-js
branch
from
bed6fe0 to
e8d1380
Compare
cprussin
left a comment
cprussin
left a comment
There was a problem hiding this comment.
LGTM but @cctdaniel and I spoke and I think it's very unwise to be 1) generating type declarations into a src dir and 2) re-exporting generated types. It's really not how typescript packaging is intended to work and I think we're very likely going to run into weird limitations because we're kind of abusing typescript here.
I think it would be wise to eventually do one of two things:
- Move the generated types to a separate package
- Move the generated types to a separate export using subpath exports
I don't think we need to do either for this PR, but I'm noting this because I think we should resist copying this pattern to another package when the opportunity comes
target_chains/fuel/sdk/js/src/types/factories/PythContractAbi__factory.ts
Show resolved
Hide resolved
|
Note the eslint error in CI |
|
@cprussin I totally hear you on this. Please feel free to modify the structure here. This PR just solves the bugs that exists which prevented me to run contract manager scripts totally irrelevant to this change. |
This change adds type generation to the build path to have them in the resulting library and also fixes the issues around type exports by updating the typescript and using
export type *. The problem was that the normalexport *adds a similar export to the produced js file but there is no module to be exported from in our case.