[entropy] Add Fee Manager Role #1623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
jayantk
commented
May 28, 2024
| (bool sent, ) = msg.sender.call{value: amount}(""); | ||
| require(sent, "withdrawal to msg.sender failed"); | ||
|
|
||
| emit Withdrawal(msg.sender, msg.sender, amount); |
Contributor
Author
There was a problem hiding this comment.
drive-by: we didn't have an event for this action
m30m
approved these changes
May 29, 2024
Contributor
m30m
left a comment
m30m
left a comment
There was a problem hiding this comment.
LGTM, you may want to add another event for setting the fee manager.
Also please bump the solidity version before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new role of a fee manager who is allowed to set / withdraw fees on behalf of a provider. The provider has the authority to set their fee manager.