[solana push oracle] Idempotent updates #1452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jayantk
commented
Apr 12, 2024
| None, | ||
| ) | ||
| .await | ||
| .unwrap(); |
Contributor
Author
There was a problem hiding this comment.
note that the account state is checked to be feed_1_recent directly below this already. I changed the update message ^ to feed_1_old to validate that the on-chain state is unchanged.
guibescos
reviewed
Apr 12, 2024
|
|
||
| require!( | ||
| price_feed_account.price_message.feed_id == feed_id, | ||
| PushOracleError::PriceFeedMessageMismatch |
Contributor
There was a problem hiding this comment.
Seems inefficient to deserialize PriceUpdateV2... though I agree it feels better to have this check here
Contributor
There was a problem hiding this comment.
Let me check how many CUs we spend doing this
guibescos
approved these changes
Apr 12, 2024
Contributor
|
Let's merge since the logic is good and we'll think later about the CU optimizations if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone tries to update a feed with a stale price, ignore the update instead of throwing an error.