refactor(hermes): state->price_feed_metadata downcasting #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
ali-behjati
reviewed
Apr 10, 2024
Comment on lines
+36
to
+47
| /// Manually implement `Clone` as the derive macro will try and slap `Clone` on | ||
| /// `State` which should not be Clone. | ||
| impl<S> Clone for ApiState<S> { | ||
| fn clone(&self) -> Self { | ||
| Self { | ||
| state: self.state.clone(), | ||
| ws: self.ws.clone(), | ||
| metrics: self.metrics.clone(), | ||
| update_tx: self.update_tx.clone(), | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Hmmm it is strange that clone doesn't work as expected here. Can you explain more?
Contributor
Author
There was a problem hiding this comment.
Rust's Clone derive is a bit basic and will automatically add T: Clone for each generic. I could mark State as Clone as it won't actually get cloned, but that introduces the risk a clone happens elsewhere in the future so opted for this.
ali-behjati
approved these changes
Apr 10, 2024
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1432 and #1435