feat(entropy-v2): request with callback #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

0xfirefist merged 41 commits into main from entropy-v2/contract

Mar 11, 2024

Contributor

0xfirefist commented Mar 5, 2024

No description provided.

vercel bot commented Mar 5, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
example-oracle-amm	⬜️ Ignored (Inspect)	Visit Preview		Mar 11, 2024 8:22pm
xc-admin-frontend	⬜️ Ignored (Inspect)	Visit Preview		Mar 11, 2024 8:22pm

m30m reviewed

View reviewed changes

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/EntropyEvents.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/EntropyErrors.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

0xfirefist marked this pull request as ready for review

March 7, 2024 09:04

0xfirefist added 8 commits

March 7, 2024 14:36


          request with callback

e0af292


          address comments

ddc87ed


          pre-commit

cfc07cc


          compilation successful

a86e9c0


          pre-commit

8aeb984


          add tests

42a32fb


          generate-abis

70745ce


          pre-commit

c5a9ec1

0xfirefist force-pushed the entropy-v2/contract branch from b908cf3 to c5a9ec1 Compare

March 7, 2024 09:07


          correct version

d1e45b3

m30m reviewed

View reviewed changes

Contributor

m30m left a comment

Please fix the comments before merge.
Can you attach a gas benchmark too? Just to make sure the additional helper functions we added are not increasing the gas usage too much.

target_chains/ethereum/entropy_sdk/solidity/EntropyEvents.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/EntropyErrors.sol Outdated Show resolved Hide resolved

0xfirefist added 4 commits

March 7, 2024 16:48


          address comments

65978d1


          pre-commit

3f3b101


          remove unused

bdca251


          add comments

de2557f

m30m approved these changes

View reviewed changes

0xfirefist added 2 commits

March 7, 2024 16:57


          pre-commit

e1cf25d


          gen abi

jayantk reviewed

View reviewed changes

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

jayantk reviewed

View reviewed changes

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/IEntropyConsumer.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/IEntropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/IEntropy.sol Outdated Show resolved Hide resolved

0xfirefist added 7 commits

March 8, 2024 16:25


          naming consistency

221cdb1


          remove gas limit comment

fc1d251


          requestWithCallback comment

ee8bbed


          remove unnecessary asserts

3ad22a0


          pre commit

1623c2d


          update request with callback coment

6f3ffc1


          abis regen

787d2d6

0xfirefist added 8 commits

March 9, 2024 00:00


          refactor as per feedback

02c16a2


          abi gen

2e8a8e9


          rename

532d566


          implement ientropyconsumer

257ac25


          gen abi

6c307ca


          comment entropy consumer

16f83e7


          test fix

c825136


          add comment

4ed0312

m30m reviewed

View reviewed changes

target_chains/ethereum/entropy_sdk/solidity/EntropyEvents.sol Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Show resolved Hide resolved

0xfirefist added 7 commits

March 11, 2024 15:26


          reintroduce blockhash


          add error for invalid reveal call

e190dfa


          use getEntropy in entropy consumer

435dc3b


          add test for requestAndRevealWithCallback

69160aa


          pass through for entropy consumer

4a6675b


          pre commit fix

ceae64d


          abi gen

472943e

m30m approved these changes

View reviewed changes

target_chains/ethereum/entropy_sdk/solidity/IEntropyConsumer.sol Outdated Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/EntropyErrors.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/forge-test/Entropy.t.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/EntropyEvents.sol Outdated Show resolved Hide resolved


          address comments

8984b6a

jayantk approved these changes

View reviewed changes

Contributor

jayantk left a comment

thanks this looks good to me. I see amin had a comment about tests, but feel free to merge without another look from me.

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Outdated Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Show resolved Hide resolved

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol Show resolved Hide resolved

target_chains/ethereum/entropy_sdk/solidity/IEntropyConsumer.sol Outdated Show resolved Hide resolved

0xfirefist added 3 commits

March 12, 2024 01:50


          address feedback

f3343bf


          gen abis

75871a0


          pre commit run

df799b1

0xfirefist merged commit e7bf47a into main

0xfirefist deleted the entropy-v2/contract branch

March 11, 2024 20:28

Contributor Author

0xfirefist commented Mar 12, 2024

Relevant gas usage changes:

testSetProviderUriByUnregistered() (gas: 0 (0.000%)) 
testGetFee() (gas: 22 (0.017%)) 
testOverflow() (gas: 50 (0.039%)) 
testGetProviderInfo() (gas: -43 (-0.094%)) 
testSetProviderUri() (gas: -130 (-0.197%)) 
testSetProviderFee() (gas: -119 (-0.229%)) 
testNoSuchProvider() (gas: 55 (0.236%)) 
testSetProviderFeeByUnregistered() (gas: 44 (0.242%)) 
testFees() (gas: 3456 (0.375%)) 
testConcurrentRequests() (gas: 6601 (0.854%)) 
testProviderCommitmentRotation() (gas: 6366 (0.955%)) 
testOutOfRandomness() (gas: 90026 (1.003%)) 
testCheckOnBlockNumberWhenBlockHashUsed() (gas: 2310 (1.300%)) 
testNoCheckOnBlockNumberWhenNoBlockHashUsed() (gas: 4956 (1.332%)) 
testAuthorization() (gas: 2357 (1.339%)) 
testBlockhash() (gas: 2504 (1.461%)) 
testDefaultProvider() (gas: 2880 (1.518%)) 
testAdversarialReveal() (gas: 17808 (1.960%)) 
testBasicFlow() (gas: 11466 (6.361%)) 
Overall gas change: 150609 (1.077%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet