feat(xc-admin): add support for setMaxLatency instruction #1328
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| }, | ||
| "dependencies": { | ||
| "@coral-xyz/anchor": "^0.26.0", | ||
| "@coral-xyz/anchor": "^0.28.1-beta.1", |
There was a problem hiding this comment.
this has to be the same as the version of @coral-xyz/anchor that @pythnetwork/client is using
| const provider = new AnchorProvider( | ||
| connection, | ||
| squads.wallet, | ||
| squads.wallet as Wallet, |
There was a problem hiding this comment.
upgraded @coral-xyz/anchor version and now AnchorProvider requires a slightly different Wallet interface but squads.wallet is still using an old version of @projectserum/anchor package
| setData(sortDataMemo(symbolToData)) | ||
| } | ||
| }, [rawConfig, dataIsLoading, sortDataMemo]) | ||
| }, [rawConfig, dataIsLoading, sortDataMemo, cluster]) |
There was a problem hiding this comment.
missing dependency cluster since it is being used in the useEffect hook
There was a problem hiding this comment.
mmmm I'm not sure about this, maybe it's fine because changing cluster updates some of the other deps
cctdaniel
force-pushed
the
max-latency
branch
from
51ce5d2 to
6e5b61b
Compare
contract_manager/package.json
Outdated
| "url": "git+https://github.com/pyth-network/pyth-crosschain.git" | ||
| }, | ||
| "dependencies": { | ||
| "@coral-xyz/anchor": "^0.28.1-beta.1", |
There was a problem hiding this comment.
this package was using @coral-xyz/anchor but didnt pin the version here hence it was using an old version of the package that some other packages are using, generally I think its a good idea to pin versions specific to packages
| const programAuthorityEscrowIdl = await Program.fetchIdl( | ||
| PROGRAM_AUTHORITY_ESCROW, | ||
| vault.getAnchorProvider() | ||
| vault.getAnchorProvider() as AnchorProvider |
There was a problem hiding this comment.
These casts are not needed
governance/xc_admin/packages/xc_admin_frontend/components/common/SocialLinks.tsx
Show resolved
Hide resolved
guibescos
left a comment
guibescos
left a comment
There was a problem hiding this comment.
Please check the comments
I upgraded
@pythnetwork/clientto the latest version to supportmaxLatencyhowever, in the latest js package, its using"@coral-xyz/anchor": "^0.28.1-beta.1"and so there were errors resulting from the packages having inconsistent versions and therefor I upgraded the versions in the relevant packages to be consistent