add /v2/updates/price/latest endpoint #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
ali-behjati
reviewed
Jan 12, 2024
ali-behjati
reviewed
Jan 12, 2024
ali-behjati
reviewed
Jan 12, 2024
ali-behjati
reviewed
Jan 12, 2024
ali-behjati
reviewed
Jan 12, 2024
ali-behjati
reviewed
Jan 12, 2024
ali-behjati
reviewed
Jan 19, 2024
| #[schema(value_type = Option<u64>, example=85480034)] | ||
| pub slot: Option<Slot>, | ||
| #[schema(value_type = Option<i64>, example=doc_examples::timestamp_example)] | ||
| pub proof_available_time: Option<UnixTimestamp>, |
Collaborator
There was a problem hiding this comment.
for the future: can we make this a ms-resolution timestamp?
ali-behjati
approved these changes
Jan 19, 2024
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
LGTM. I left a comment on changing the proof_available_timestamp to have millisecond resolution which can be done in subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement new v2 endpoint for /updates/price/latest which is a merge of the existing endpoints as follow:
/api/latest_price_feeds?ids[]=<price_feed_id>&ids[]=<price_feed_id_2>&..(&verbose=true)(&binary=true)/api/latest_vaas?ids[]=<price_feed_id>&ids[]=<price_feed_id_2>&...the proposed v2 endpoint is as follow:
/v2/updates/price/latest?ids[]=<price_feed_id>&ids[]=<price_feed_id_2>&..(&encoding=hex|base64)(&parsed=false)encodingdefaults tohexandparseddefaults totrueas per design guidelinethis PR serves at an initial stab at the endpoint, will follow up with a separate PR for the tests