[entropy] Add entropy ABIs to solidity sdk #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jayantk
commented
Jan 9, 2024
| @@ -0,0 +1,54 @@ | |||
| const fs = require("fs"); | |||
Contributor
Author
There was a problem hiding this comment.
I copy/pasted this from the other solidity SDK. It's somewhat unfortunate that this code is duplicated, but we don't have a good place for shared javascript and I don't want to solve that problem right now.
0xfirefist
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the ABIs for the contracts and put them in the solidity SDK. The JS sdk will depend on the solidity SDK to get access to these ABIs
I've set this up exactly the same as how we've done it for price feeds. I slightly generalized the CI check for ABIs so that it applies to both sdks.