feat(hermes): add uniqueness check for benchmark price #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
m30m
reviewed
Oct 24, 2023
| .next() | ||
| .ok_or(RestError::UpdateDataNotFound)?; | ||
|
|
||
| // Currently Benchmarks API doesn't support returning the previous publish time. So we |
Contributor
There was a problem hiding this comment.
is this comment also valid here?
Collaborator
Author
There was a problem hiding this comment.
yeah i think they don't return it
m30m
reviewed
Oct 24, 2023
|
|
||
| let publish_time = price_feed.price_feed.get_price_unchecked().publish_time; | ||
|
|
||
| // Currently Benchmarks API doesn't support returning the previous publish time. So we |
Contributor
There was a problem hiding this comment.
if you expect the benchmark service to return 404 if not unique, why do we have this check here?
Collaborator
Author
There was a problem hiding this comment.
This applies to the cache of Hermes.
m30m
approved these changes
Oct 24, 2023
Contributor
m30m
left a comment
m30m
left a comment
There was a problem hiding this comment.
lgtm, added some minor comments
Reisen
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.