feat: aggregate in the same slot #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cctdaniel
commented
Feb 21, 2024
guibescos
reviewed
Feb 21, 2024
ali-behjati
reviewed
Feb 22, 2024
cctdaniel
changed the title
cctdaniel
changed the title
cctdaniel
force-pushed
the
same-slot-agg
branch
from
793accf to
ce47715
Compare
guibescos
reviewed
Mar 19, 2024
guibescos
reviewed
Mar 19, 2024
guibescos
reviewed
Mar 19, 2024
guibescos
reviewed
Mar 19, 2024
guibescos
reviewed
Mar 19, 2024
ali-behjati
previously approved these changes
Apr 9, 2024
jayantk
previously approved these changes
Apr 9, 2024
ali-behjati
previously approved these changes
Apr 10, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 12, 2024
guibescos
reviewed
Apr 15, 2024
guibescos
previously approved these changes
Apr 15, 2024
ali-behjati
approved these changes
Apr 16, 2024
ali-behjati
added a commit
that referenced
this pull request
May 3, 2024
This reverts commit 65949e0.
ali-behjati
added a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update aggregation logic to aggregate in the same slot, also change ema and twap to calculate on the same slot