pyth.cpp: upd_price takes price value, confidence and symbol status #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mass
reviewed
Aug 13, 2021
drozdziak1
force-pushed
the
upd_price_args
branch
from
98335b4 to
fd8b367
Compare
mass
reviewed
Aug 16, 2021
Contributor
mass
left a comment
mass
left a comment
There was a problem hiding this comment.
Looks great, thank you! Just a couple of comments:
drozdziak1
force-pushed
the
upd_price_args
branch
from
fd8b367 to
97bf5ce
Compare
drozdziak1
force-pushed
the
upd_price_args
branch
from
97bf5ce to
9c96c26
Compare
mass
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows writing
./pyth upd_price_valwhich takes an explicit price, confidence interval and status value for publishing.