Use custom bpf-tools #319
Merged
Use custom bpf-tools #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptaffet
approved these changes
Nov 28, 2022
ptaffet
left a comment
ptaffet
left a comment
There was a problem hiding this comment.
We should consider moving these repos out of guibescos if Solana takes a long time to merge these, but for now this looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current solana-labs bpf-tools (the toolchain that builds bpf programs), the flags
-Z build-std=std,panic_abortdon't work. These flags compile the standard rust library from scratch and make the program smaller.There is evidence that the solana team plans to release a version that support this : https://github.com/solana-labs/solana/blob/9f370475d40dbe68f1a51d34fc3df07e5327d6c3/sdk/cargo-build-sbf/src/main.rs#L625
This PR is meant to make the repo use a fork of bpf-tools instead of the solana-labs release. The only difference between the my fork and solana-labs is that my fork uses https://github.com/solana-labs/compiler-builtins/tree/sbf-tools-v1.30 instead of https://github.com/solana-labs/compiler-builtins/tree/bpf-tools-v1.27 (a package bump basically) .
TLDR : I think the solana team is gonna make a release eventually enabling what I want to do (the changes have made it to the master branch of solana but not the releases yet) but I don't really want to wait.