Make PDA init simpler #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
force-pushed
the
guibescos/simple-pda-init
branch
from
08584bf to
2190e0f
Compare
jayantk
approved these changes
Nov 28, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
i guess this is fine -- even if someone exploits this, we can always update the code to handle it.
i suggest writing down a list of PRs to revert once the code size issue gets fixed. It's a little unfortunate to lose our robustness to these kinds of issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
97k -> 92k
More details on ptal.